[Maskprocessor] Guidance for a Hopeful Newb Contributor

Dobray notes! (Hello!)

I modified the source of mp64.c to be able to specify how many times a certain charset will appear (max or exact) in the generated output regardless of position. Eg: EXACT: 1 symbol, 2 lowers, 0 numbers ?a?a?a?a?a?a will give outputs with exactly 1 symbol, 2 lowers, 0 numbers and 3 uppers, but the order does not matter.


The function is run at the the end and is basically an 'exclude' filter. I am positive my code could be made faster. However, when used with rules in hashcat, this is not the bottleneck (at least on my hardware).

I understand this is super-trivial to implement, yet I have not seen it implemented.

How do I go about submitting this to the devs? Do they/anyone else care about this? What work needs to be done to make this good enough to be incorporated?

Attached is my raw source. I also have a "save every N number of tries" function in there. This makes it easier to save progress when piping into hashcat. Again, trivial, but I couldn't find it anywhere else.

  mp.txt (Size: 31.79 KB / Downloads: 1)